Compile panic expression to ABI error codes#7118
Merged
Merged
Conversation
43f1861 to
f411839
Compare
Member
Author
|
This PR is blocked by #7073. It integrates the newest The next step in the integration of CC: @hal3e. |
f411839 to
0bb4fa5
Compare
0bb4fa5 to
be13470
Compare
be13470 to
65a9c8c
Compare
CodSpeed Performance ReportMerging #7118 will not alter performanceComparing Summary
|
IGI-111
reviewed
May 27, 2025
IGI-111
approved these changes
May 27, 2025
xunilrj
approved these changes
May 27, 2025
JoshuaBatty
approved these changes
May 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is the final step in implementing the
panicexpression and the ABI errors, as defined in the ABI Errors RFC.The PR generates the
errorCodessection in the ABI, like, e.g.:If the
panicargument is a string slice that can be const-evaluated, themsgfield of the corresponding error code is generated, and a log is not emitted. The string itself is stored only within the ABI JSON, and is not included into the generated bytecode.Additionally, the PR:
SourceLocationfrom aSpan. This is currently used in the implementation of the__dbgintrinsics and thepanicexpression.forcoutputs in snapshot tests by supporting regular expressions. Thegrepcommand is renamed toregexto avoid confusion with piping the actualgrepCLI command.Partially addresses #6765.
Checklist
Breaking*orNew Featurelabels where relevant.